Make Android app shortcut use 'Home Assistant' as name.#8261
Merged
Conversation
Merged
balloob
added a commit
that referenced
this pull request
Jul 1, 2017
* Revert "Version bump to 0.49.0.dev0 (#8266)" This reverts commit 8e4394f. * Revert "Adding done_message to alert (#8116)" This reverts commit 5e56bc7. * Revert "Camera services arm disarm including Netgear Arlo (#7961)" This reverts commit ed20f7e. * Revert "Make Android app shortcut use 'Home Assistant' as name instead of just 'Assistant'. (#8261)" This reverts commit 0bcb783.
Member
|
This should not have been merged and needs more discussion. The reason the name is "Assistant" is because otherwise the name will be cutoff on the home screen and it will be "Home Ass…" |
Member
|
(that's also why the property is called |
balloob
added a commit
that referenced
this pull request
Jul 1, 2017
* Revert "Version bump to 0.49.0.dev0 (#8266)" This reverts commit 8e4394f. * Revert "Adding done_message to alert (#8116)" This reverts commit 5e56bc7. * Revert "Camera services arm disarm including Netgear Arlo (#7961)" This reverts commit ed20f7e. * Revert "Make Android app shortcut use 'Home Assistant' as name instead of just 'Assistant'. (#8261)" This reverts commit 0bcb783.
Contributor
Author
|
Hmm, it's "Home Assi.." on default font size here, and "Home Assista.." on small font. The downside is that Android always uses the short name, like in the task switcher where there is enough space for the full name. I've gotten used to all the abreviations on the home screen that I haven't noticed it's abreviated. I did notice the "Assistant" name wasn't actually correct. |
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
…e-assistant#8271) * Revert "Version bump to 0.49.0.dev0 (home-assistant#8266)" This reverts commit 8e4394f. * Revert "Adding done_message to alert (home-assistant#8116)" This reverts commit 5e56bc7. * Revert "Camera services arm disarm including Netgear Arlo (home-assistant#7961)" This reverts commit ed20f7e. * Revert "Make Android app shortcut use 'Home Assistant' as name instead of just 'Assistant'. (home-assistant#8261)" This reverts commit 0bcb783.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when you create a shortcut to Home Assistant on Android, it suggests the name "Assistant" instead of "Home Assistant".
I think "Home Assistant" is the correct name for the app to clearly differentiate with Google Assistant or other Assistants.
Check out the animation on this page to see the "Assistant" name.